Add multi phone numbers support by titilambert · Pull Request #6605 · home-assistant/core

titilambert · 2017-03-13T22:44:23Z

Description:

As @tanilolli requested (here #5997), this PR add the multi phone number support.

Please don't merge this PR. I'm waiting for @tanilolli confirmation for cleaning.

@tanilolli Could you confirm that this patch is working for you ?

Related issue (if applicable): fixes #5997

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#2256

Example entry for `configuration.yaml` (if applicable):

sensor:
  - platform: fido
    username: MYUSERNAME
    password: MYPASSWORD
    monitored_variables:
     - fido_dollar
     - balance
     - data_used

Checklist:

Documentation added/updated in home-assistant.github.io
Local tests with tox run successfully. Your PR cannot be merged unless tests pass
New dependencies have been added to the REQUIREMENTS variable (example).
New dependencies are only imported inside functions that use them (example).
New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
New files were added to .coveragerc.

anthonydiiorio · 2017-03-14T02:42:11Z

It works great with a single instance of the component. When I add multiple Fido sensors, initially some of the accounts give this error:
Error on receive last Fido data: Can not get token or uuid

After some time, all accounts do get updated though.

titilambert · 2017-03-15T01:17:27Z

@tanilolli do you have this sometimes or only at startup ?

anthonydiiorio · 2017-03-15T01:20:03Z

@titilambert Only at startup

titilambert · 2017-03-15T01:21:26Z

@tanilolli EVERYTIME your start HA ? (Is it reproducible ?)

anthonydiiorio · 2017-03-15T01:26:55Z

@titilambert Yes, everytime. It seems the issue is Fido doesn't like the requests being made so fast.

titilambert · 2017-03-15T01:33:58Z

@tanilolli yes I guess,... So I don't know what to do for that :(
Do you have any idea ?

titilambert · 2017-03-15T01:37:07Z

@balloob Can we share some data/object between to instance of the same component ?

anthonydiiorio · 2017-03-15T01:43:33Z

@titilambert Maybe the component could load all the data for the account and create it's own sensors.

sensor.fido could display general account details like balance
sensor.fido_NUMBER could display number specific details like data usage

titilambert · 2017-03-15T01:44:34Z

@tanilolli good idea, I will try it tomorrow

pvizeli · 2017-03-30T07:55:45Z

Ping, any updates?

titilambert · 2017-03-31T02:47:11Z

Sorry, my "tomorrow" is really long :/
But, I'm currently finishing it and waiting for more tests

titilambert · 2017-04-01T01:39:23Z

Ready for review !
@tanilolli Could you retry with this new version ?

houndci-bot · 2017-04-01T01:42:53Z

line too long (88 > 79 characters)

houndci-bot · 2017-04-01T01:50:08Z

line too long (84 > 79 characters)

anthonydiiorio · 2017-04-01T06:51:34Z

Thanks for the update! It's working great with all 3 numbers in my account.

pvizeli

Small code style

pvizeli · 2017-04-04T10:20:51Z

You can only use if self.fido_data.data.get(self.type): that replace this two lines.

pvizeli · 2017-04-04T10:21:09Z

houndci-bot · 2017-04-04T11:38:00Z

continuation line with same indent as next logical line

titilambert · 2017-04-04T11:43:38Z

Fixed !

pvizeli

Leave a comment

homeassistant added cla-signed platform: sensor.fido labels Mar 13, 2017

titilambert force-pushed the fido branch from 48c165f to b1fc6d7 Compare March 13, 2017 22:45

homeassistant added the cla-signed label Mar 13, 2017

titilambert mentioned this pull request Mar 13, 2017

WIP: Update fido sensor documentation home-assistant/home-assistant.io#2256

Merged

titilambert force-pushed the fido branch from b1fc6d7 to 47224c3 Compare April 1, 2017 01:28

homeassistant added the cla-signed label Apr 1, 2017

titilambert force-pushed the fido branch from 47224c3 to 8e01b22 Compare April 1, 2017 01:42

homeassistant added the cla-signed label Apr 1, 2017

balloobbot added platform requirement labels Apr 1, 2017

houndci-bot reviewed Apr 1, 2017

View reviewed changes

Comment thread homeassistant/components/sensor/fido.py Outdated

Copy link
Copy Markdown

houndci-bot Apr 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (88 > 79 characters)

titilambert force-pushed the fido branch from 8e01b22 to 898a5fd Compare April 1, 2017 01:49

homeassistant added the cla-signed label Apr 1, 2017

houndci-bot reviewed Apr 1, 2017

View reviewed changes

Comment thread homeassistant/components/sensor/fido.py Outdated

Copy link
Copy Markdown

houndci-bot Apr 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (84 > 79 characters)

titilambert force-pushed the fido branch from 898a5fd to 0a6c867 Compare April 1, 2017 01:52

homeassistant added the cla-signed label Apr 1, 2017

titilambert force-pushed the fido branch from 0a6c867 to 7242d4c Compare April 2, 2017 05:24

homeassistant added the cla-signed label Apr 2, 2017

titilambert changed the title ~~[WIP] Add multi phone numbers support~~ Add multi phone numbers support Apr 3, 2017

pvizeli requested changes Apr 4, 2017

View reviewed changes

titilambert force-pushed the fido branch from 7242d4c to 9905283 Compare April 4, 2017 11:37

homeassistant added the cla-signed label Apr 4, 2017

houndci-bot reviewed Apr 4, 2017

View reviewed changes

Comment thread homeassistant/components/sensor/fido.py Outdated

Copy link
Copy Markdown

houndci-bot Apr 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

continuation line with same indent as next logical line

Add multi phone numbers support

c986725

titilambert force-pushed the fido branch from 9905283 to c986725 Compare April 4, 2017 11:40

homeassistant added the cla-signed label Apr 4, 2017

Update fido.py

0dc88cf

pvizeli approved these changes Apr 5, 2017

View reviewed changes

pvizeli merged commit 118bd34 into home-assistant:dev Apr 5, 2017

fabaff mentioned this pull request Apr 6, 2017

0.42 #6956

Merged

home-assistant locked and limited conversation to collaborators Jul 17, 2017

ghost added integration: fido and removed platform: sensor.fido labels Mar 21, 2019

Uh oh!

Conversation

titilambert commented Mar 13, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description:

Example entry for configuration.yaml (if applicable):

Checklist:

Uh oh!

anthonydiiorio commented Mar 14, 2017

Uh oh!

titilambert commented Mar 15, 2017

Uh oh!

anthonydiiorio commented Mar 15, 2017

Uh oh!

titilambert commented Mar 15, 2017

Uh oh!

anthonydiiorio commented Mar 15, 2017

Uh oh!

titilambert commented Mar 15, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

titilambert commented Mar 15, 2017

Uh oh!

anthonydiiorio commented Mar 15, 2017

Uh oh!

titilambert commented Mar 15, 2017

Uh oh!

pvizeli commented Mar 30, 2017

Uh oh!

titilambert commented Mar 31, 2017

Uh oh!

titilambert commented Apr 1, 2017

Uh oh!

houndci-bot Apr 1, 2017

Choose a reason for hiding this comment

Uh oh!

houndci-bot Apr 1, 2017

Choose a reason for hiding this comment

Uh oh!

anthonydiiorio commented Apr 1, 2017

Uh oh!

pvizeli left a comment

Choose a reason for hiding this comment

Uh oh!

pvizeli Apr 4, 2017

Choose a reason for hiding this comment

Uh oh!

pvizeli Apr 4, 2017

Choose a reason for hiding this comment

Uh oh!

houndci-bot Apr 4, 2017

Choose a reason for hiding this comment

Uh oh!

titilambert commented Apr 4, 2017

Uh oh!

pvizeli left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

titilambert commented Mar 13, 2017 •

edited

Loading

Example entry for `configuration.yaml` (if applicable):

titilambert commented Mar 15, 2017 •

edited

Loading