[WIP] Add Fido sensor by titilambert · Pull Request #5997 · home-assistant/core

titilambert · 2017-02-14T22:09:52Z

Description:
Get your current talk/text/data usage from your Fido (http://fido.ca) account

Pull request in home-assistant.github.io with documentation: home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: fido
    username: YOUPHONENUMBER
    password: PASSWORD
    monitored_variables:
     - fido_dollar
     - balance
     - data_used
     - data_limit
     - data_remaining
     - text_used
     - text_limit
     - text_remaining
     - mms_used
     - mms_limit
     - mms_remaining
     - text_int_used
     - text_int_limit
     - text_int_remaining
     - talk
     - talk_limit
     - talt_remaining
     - talk_other
     - talk_other_limit
     - talt_other_remaining

Checklist:

Documentation added/updated in home-assistant.github.io
Local tests with tox run successfully. Your PR cannot be merged unless tests pass
New dependencies have been added to the REQUIREMENTS variable (example).
New dependencies are only imported inside functions that use them (example).
New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
New files were added to .coveragerc.

mention-bot · 2017-02-14T22:09:55Z

@titilambert, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @fabaff and @robbiet480 to be potential reviewers.

houndci-bot · 2017-02-14T22:09:58Z

undefined name 'PyEboxError'

houndci-bot · 2017-02-14T22:09:58Z

'pyfido.client.PyFidoError' imported but unused

houndci-bot · 2017-02-14T22:09:58Z

're' imported but unused

houndci-bot · 2017-02-14T22:09:58Z

'json' imported but unused

pvizeli

Looks good. Only small minor changes

pvizeli · 2017-02-15T08:03:21Z

+        self.fido_data = fido_data
+        self._state = None
+
+        self.update()


Remove that and use add_devices(sensors, True)

Where can I find the definition of this function add_devices ?

helpers/entity_component.py

pvizeli · 2017-02-15T08:09:09Z

+        try:
+            self.client.fetch_data()
+        except PyFidoError as exp:
+            _LOGGER.error(exp)


use _LOGGER.exception and add a message to it.

pvizeli · 2017-02-15T08:09:50Z

+        """Initialize the sensor."""
+        self.client_name = name
+        self.type = sensor_type
+        self.entity_id = "sensor.{}_{}".format(name, sensor_type)


You don't need that. remove it.

I just want to keep the same string between the sensor entity_id and the monitored_variables list

That will be done. But if you setup same thing twice you disrate the core. So the core will produce your entity_id and make sure that is real unique

Oki ! So I changed the name of some sensor to get something more consistent

pvizeli · 2017-02-15T08:10:22Z

+
+def setup_platform(hass, config, add_devices, discovery_info=None):
+    """Set up the Fido sensor."""
+    # Create a data fetcher to support all of the configured sensors. Then make


Cleanup this comments. It should be clear.

pvizeli

Small cleanups and ready to go 👍

pvizeli · 2017-02-15T17:59:41Z

For what is that static?

This just bad all stuff ...

pvizeli · 2017-02-15T18:00:19Z

Where is that used?

titilambert · 2017-02-15T18:53:34Z

@pvizeli just missing the documentation, I will push it later today

pvizeli · 2017-02-15T20:04:20Z

Merge after test pass. You can push your doc and refere to this. I can merge it without docu.

RiRomain · 2017-02-26T09:12:15Z

It seems the docu was not merged or not there yet (thus the WIP?):
https://home-assistant.io/components/sensor.fido/

balloob · 2017-02-26T19:57:53Z

😢

Added a doc stub.

titilambert · 2017-02-27T01:24:55Z

wtf ?! I'm doing it right now !

titilambert · 2017-02-27T01:27:47Z

@balloob done here: home-assistant/home-assistant.io#2158

anthonydiiorio · 2017-03-12T07:59:29Z

Our account uses 1 number to login but has 3 numbers associated to the account. Would you be able to add a config option for the phone number to get the data from? Right now it gets the data from the primary number only. Thanks.

titilambert · 2017-03-13T03:15:21Z

@tanilolli could you try the version 0.2.0 of pyfido: https://github.com/titilambert/pyfido
To confirm that is working with multiple phone number ?
If this is working, I will update the HA component.

Thanks

anthonydiiorio · 2017-03-13T03:50:05Z

@titilambert It works! I tested with all 3 numbers in the account and got the data I was expecting. Thank you very much!

titilambert · 2017-03-13T03:52:42Z

Nice ! I hope make the PR this week !

homeassistant added the cla-signed label Feb 14, 2017

homeassistant added new-platform platform: sensor.fido labels Feb 14, 2017

houndci-bot reviewed Feb 14, 2017

View reviewed changes

titilambert force-pushed the fido branch from ae13cb2 to 2899e16 Compare February 14, 2017 22:10

homeassistant added the cla-signed label Feb 14, 2017

titilambert force-pushed the fido branch from 2899e16 to 788ffa5 Compare February 14, 2017 22:14

homeassistant added the cla-signed label Feb 14, 2017

Add Fido sensor

9c2694b

titilambert force-pushed the fido branch from 788ffa5 to 9c2694b Compare February 14, 2017 22:15

homeassistant added the cla-signed label Feb 14, 2017

pvizeli requested changes Feb 15, 2017

View reviewed changes

homeassistant added the cla-signed label Feb 15, 2017

titilambert force-pushed the fido branch from f9a25c1 to 6cc8f7b Compare February 15, 2017 16:58

homeassistant added the cla-signed label Feb 15, 2017

pvizeli requested changes Feb 15, 2017

View reviewed changes

Fix PR home-assistant#5997 comments

6ed5fb8

titilambert force-pushed the fido branch from 6cc8f7b to 6ed5fb8 Compare February 15, 2017 18:15

homeassistant added the cla-signed label Feb 15, 2017

titilambert changed the title ~~Add Fido sensor~~ [WIP] Add Fido sensor Feb 15, 2017

Make error message usable

5625e7d

homeassistant added the cla-signed label Feb 15, 2017

pvizeli approved these changes Feb 15, 2017

View reviewed changes

pvizeli merged commit 5895f43 into home-assistant:dev Feb 15, 2017

titilambert mentioned this pull request Feb 27, 2017

Add fido sensor component documentation home-assistant/home-assistant.io#2158

Merged

titilambert mentioned this pull request Mar 13, 2017

Add multi phone numbers support #6605

Merged

6 tasks

home-assistant locked and limited conversation to collaborators Jul 17, 2017

ghost added integration: fido and removed platform: sensor.fido labels Mar 21, 2019

Uh oh!

Conversation

titilambert commented Feb 14, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mention-bot commented Feb 14, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pvizeli left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

titilambert Feb 15, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pvizeli left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

titilambert commented Feb 15, 2017

Uh oh!

pvizeli commented Feb 15, 2017

Uh oh!

RiRomain commented Feb 26, 2017

Uh oh!

balloob commented Feb 26, 2017

Uh oh!

titilambert commented Feb 27, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

titilambert commented Feb 27, 2017

Uh oh!

anthonydiiorio commented Mar 12, 2017

Uh oh!

titilambert commented Mar 13, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anthonydiiorio commented Mar 13, 2017

Uh oh!

titilambert commented Mar 13, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

titilambert commented Feb 14, 2017 •

edited

Loading

titilambert Feb 15, 2017 •

edited

Loading

titilambert commented Feb 27, 2017 •

edited

Loading

titilambert commented Mar 13, 2017 •

edited

Loading