Skip to content

WIP: Update fido sensor documentation#2256

Merged
fabaff merged 1 commit into
home-assistant:nextfrom
titilambert:fido
Apr 5, 2017
Merged

WIP: Update fido sensor documentation#2256
fabaff merged 1 commit into
home-assistant:nextfrom
titilambert:fido

Conversation

@titilambert
Copy link
Copy Markdown
Contributor

Description:
Add multi phone number support

Pull request in home-assistant (if applicable): home-assistant/core#6605

@mention-bot
Copy link
Copy Markdown

@titilambert, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob and @fabaff to be potential reviewers.

Comment thread source/_components/sensor.fido.markdown Outdated
- platform: fido
username: MYUSERNAME
password: MYPASSWORD
number: MYPHONENUMBER
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional variables should not be included in the example.
Feel free to add an advanced example.

@Landrash Landrash added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label Mar 17, 2017
@titilambert titilambert changed the title Update fido sensor documentation WIP: Update fido sensor documentation Mar 18, 2017
Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🐦

@fabaff fabaff dismissed Landrash’s stale review April 5, 2017 17:44

Comment was addressed.

@fabaff fabaff merged commit ce71b24 into home-assistant:next Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-feature This PR adds documentation for a new Home Assistant feature to an existing integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants