Weather units: knx to metoffice (3/4)

[rianadon]

Proposed change

Uses the new weather conversion in the weather entity ( #59533) to convert weather values to the configured units.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[probot-home-assistant]

Hey there @Julius2342, @farmio, @marvin-w, mind taking a look at this pull request as it has been labeled with an integration (knx) you are listed as a code owner for? Thanks!
_{^{(message by CodeOwnersMention)}}

[probot-home-assistant]

Hey there @DylanGore, mind taking a look at this pull request as it has been labeled with an integration (met_eireann) you are listed as a code owner for? Thanks!
_{^{(message by CodeOwnersMention)}}

[probot-home-assistant]

Hey there @MrHarcombe, mind taking a look at this pull request as it has been labeled with an integration (metoffice) you are listed as a code owner for? Thanks!
_{^{(message by CodeOwnersMention)}}

[probot-home-assistant]

Hey there @Danielhiversen, @thimic, mind taking a look at this pull request as it has been labeled with an integration (met) you are listed as a code owner for? Thanks!
_{^{(message by CodeOwnersMention)}}

[probot-home-assistant]

Hey there @hacf-fr, @oncleben31, @Quentame, mind taking a look at this pull request as it has been labeled with an integration (meteo_france) you are listed as a code owner for? Thanks!
_{^{(message by CodeOwnersMention)}}

[probot-home-assistant]

Hey there @adrianmo, mind taking a look at this pull request as it has been labeled with an integration (meteoclimatic) you are listed as a code owner for? Thanks!
_{^{(message by CodeOwnersMention)}}

[marvin-w]

KNX looks good, just a minor cosmetic change!

[adrianmo]

All good on the Meteoclimatic side - thanks for the update @rianadon !

[oncleben31]

Seems OK for meteo_france. Thank you.

[marvin-w]

@rianadon Please rebase again and fix the conflicts

[Quentame]

LGFM for meteo_france

[MrHarcombe]

Hey there @MrHarcombe, mind taking a look at this pull request as it has been labeled with an integration (metoffice) you are listed as a code owner for? Thanks! (message by CodeOwnersMention)

Slight problem, being the UK MetOffice is that the units given aren't correct. According to the API reference, for starters, the wind speed is given in miles per hour, not kilometers per hour. Sorry.

[avee87]

Yeah MetOffice returns mph for wind speed. Unfortunately, it means that you will need to update tests which will have different values for wind speed because tests run with metric system.

[rianadon]

Thank you all for the corrections! I hope I got the units right this time.

[avee87]

MetOffice looks good but please check my comment in code

[marvin-w]

KNX looks good now, thanks!

[frenck]

Rebased to deal with the merge conflict.

[frenck]

This is a massive breaking change.

Also:

• Opened up Revert "Weather units: climacell (1.3/4)" #63842 to revert Weather units: climacell (1.3/4) #61472, which does a similar thing as this PR.
• Opened up Revert "Weather units: Buienradar (1.2/4)" #63843 to revert Weather units: Buienradar (1.2/4) #61470, which does a similar thing as this PR.


[github-actions]

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.