Skip to content

Add new tomorrow.io integration to replace Climacell#63325

Closed
raman325 wants to merge 5 commits intodevfrom
climacell_to_tomorrowio
Closed

Add new tomorrow.io integration to replace Climacell#63325
raman325 wants to merge 5 commits intodevfrom
climacell_to_tomorrowio

Conversation

@raman325
Copy link
Copy Markdown
Contributor

@raman325 raman325 commented Jan 3, 2022

Breaking change

ClimaCell as a company rebranded to Tomorrow.io and as such we will be deprecating the climacell integration in favor of the new tomorrowio integration. For any climacell users using a v4 API key, the migration from the old integration to the new one will happen automatically. If you are a climacell user using a v3 API key, you will need to sign up for a v4 API key in order to complete the migration, but once you have provided the new key, your config entry (or entries) will be migrated over automatically.

For now, v3 users will still have access to their existing ClimaCell config entries before they submit the new API key so that your automations and dashboards still work. In a future release, we will be removing most of the code from the climacell integration so that the migrations will still happen but the original integration will no longer work.

Proposed change

ClimaCell as a company rebranded to Tomorrow.io right around when we introduced the climacell integration 🙃 After consulting some other members, I decided to build a new integration which is more or less a stripped down version of climacell (climacell supported two different APIs, this one only supports the one that's currently supported by the company). This overall effort was split into three separate parts to make it easier to review:

This PR is the final PR to merge all of these parts into dev

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

raman325 and others added 3 commits January 3, 2022 14:35
* Add new tomorrow.io integration to replace Climacell - Part 1/3

* remove unused code

* remove extra test

* remove more unused code

* Remove even more unused code

* Feedback

* clean up options flow

* clean up options flow

* tweaks and fix tests

* remove device_class from tomorrowio entity description class

* use timestep

* fix tests

* always use default name but add zone name if location is in a zone

* revert change that will go into future PR

* review comments

* move code out of try block

* bump max requests to 500 as per docs

* fix tests
* Add new tomorrow.io integration to replace Climacell - Part 2/3

* translations

* set config flow to false in manifest

* Cleanup more code and re-add options flow test

* fixes

* patch I/O calls

* Update tests/components/climacell/test_config_flow.py

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>

* remove unused import

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@raman325 raman325 force-pushed the climacell_to_tomorrowio branch from fcd7884 to a157af6 Compare January 3, 2022 19:40
@frenck frenck closed this in #63526 Jan 7, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants