Skip to content

Add state translations and icons to ClimaCell sensors#63526

Merged
frenck merged 2 commits intohome-assistant:devfrom
raman325:climacell
Jan 7, 2022
Merged

Add state translations and icons to ClimaCell sensors#63526
frenck merged 2 commits intohome-assistant:devfrom
raman325:climacell

Conversation

@raman325
Copy link
Copy Markdown
Contributor

@raman325 raman325 commented Jan 6, 2022

Proposed change

State translations were requested in #63494 . Note that #63325 will eventually get merged so the utility of this is somewhat short lived, but the same changes will be applied to that PR and will be done more completely (e.g. more icons will be added).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jan 6, 2022
Copy link
Copy Markdown
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (but untested)

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks, @raman325 👍

@frenck frenck merged commit 6d42af1 into home-assistant:dev Jan 7, 2022
@raman325 raman325 deleted the climacell branch January 7, 2022 17:30
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

by-code-owner cla-signed integration: climacell new-feature smash Indicator this PR is close to finish for merging or closing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants