Skip to content

Add new tomorrow.io integration to replace Climacell - Part 1/3#57121

Merged
raman325 merged 18 commits intohome-assistant:climacell_to_tomorrowiofrom
raman325:tomorrowio_new
Oct 17, 2021
Merged

Add new tomorrow.io integration to replace Climacell - Part 1/3#57121
raman325 merged 18 commits intohome-assistant:climacell_to_tomorrowiofrom
raman325:tomorrowio_new

Conversation

@raman325
Copy link
Copy Markdown
Contributor

@raman325 raman325 commented Oct 5, 2021

Proposed change

I will be merging this in pieces and then we will do one big merge once all parts are done
This is part 1 of 3: Create new tomorrowio integration

ClimaCell as a company rebranded to Tomorrow.io right around when we introduced the climacell integration 🙃 After consulting some other members, I decided to build a new integration which is more or less a stripped down version of climacell (climacell supported two different APIs, this one only supports the one that's currently supported by the company). This overall effort is split into three separate parts to make it easier to review per Martin's suggestion:

  • Part 1: Create new tomorrowio integration. This uses a new library but the underlying code in the library is the exact same as the v4 API logic in pyclimacell. Similarly the integration logic is a simplified version of the climacell integration since v3 is deprecated: Add new tomorrow.io integration to replace Climacell - Part 1/3 #57121
  • Part 2: Remove config flow from climacell and replace it with a message to install tomorrowio integration instead
  • Part 3: Auto-migrate climacell config entries that are using the v4 API and semi-auto migrate ones that use the v3 API
  • Final Step: Merge all three parts together into dev (this will include the documentation updates)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@raman325 raman325 merged commit e943c2e into home-assistant:climacell_to_tomorrowio Oct 17, 2021
@raman325 raman325 deleted the tomorrowio_new branch October 17, 2021 07:14
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants