Do not create a number LED brightness entity for Xiaomi Miio devices that do not support it#62819
Merged
balloob merged 3 commits intoJan 4, 2022
Conversation
|
This pull request needs to be manually signed off by @home-assistant/core before it can get merged. |
|
Hey there @rytilahti, @syssi, @starkillerOG, mind taking a look at this pull request as it has been labeled with an integration ( |
balloob
reviewed
Jan 4, 2022
balloob
approved these changes
Jan 4, 2022
balloob
reviewed
Jan 4, 2022
| from dataclasses import dataclass | ||
|
|
||
| from homeassistant.components.number import NumberEntity, NumberEntityDescription | ||
| from homeassistant.components.number.const import DOMAIN as PLATFORM_DOMAIN |
Member
There was a problem hiding this comment.
you can import this from homeassistant.components.number directly. also namei t NUMBER_DOMAIN
balloob
added a commit
that referenced
this pull request
Jan 4, 2022
…that do not support it (#62819) Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
Merged
This was referenced Jan 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
After #60134
numberLED Brightness entity is created for models that don't support it.FEATURE_SET_LED_BRIGHTNESSuses theselectplatform for most of the models. With this change, mistaken created entities will be removed andnumberLED Brightness entity will be created only for ZA5 fan.Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: