Skip to content

Do not create a number LED brightness entity for Xiaomi Miio devices that do not support it #62819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 3 commits into from
Jan 4, 2022
+10 −0
Merged

Do not create a number LED brightness entity for Xiaomi Miio devices that do not support it #62819

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
66ec37d
Remove led brightnes entity
bieniu Dec 26, 2021
61a252e
Isort
bieniu Jan 1, 2022
53bd5b8
Update homeassistant/components/xiaomi_miio/number.py
balloob Jan 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions homeassistant/components/xiaomi_miio/number.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
from dataclasses import dataclass

from homeassistant.components.number import NumberEntity, NumberEntityDescription
from homeassistant.components.number.const import DOMAIN as PLATFORM_DOMAIN
Copy link
Copy Markdown
Member

@balloob balloob Jan 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can import this from homeassistant.components.number directly. also namei t NUMBER_DOMAIN

from homeassistant.config_entries import ConfigEntry
from homeassistant.const import DEGREE, TIME_MINUTES
from homeassistant.core import HomeAssistant, callback
Expand Down Expand Up @@ -252,6 +253,15 @@ async def async_setup_entry(
return

for feature, description in NUMBER_TYPES.items():
if feature == FEATURE_SET_LED_BRIGHTNESS and model != MODEL_FAN_ZA5:
# Delete LED bightness entity created by mistake if it exists
entity_reg = hass.helpers.entity_registry.async_get()
entity_id = entity_reg.async_get_entity_id(
PLATFORM_DOMAIN, DOMAIN, f"{description.key}_{config_entry.unique_id}"
)
if entity_id:
entity_reg.async_remove(entity_id)
continue
if feature & features:
if (
description.key == ATTR_OSCILLATION_ANGLE
Expand Down