Skip to content

Add LED brightness for Xiaomi Miio ZA5 fan#60134

Merged
frenck merged 2 commits into
home-assistant:devfrom
bieniu:xiaomi_miio/led_brightness
Nov 23, 2021
Merged

Add LED brightness for Xiaomi Miio ZA5 fan#60134
frenck merged 2 commits into
home-assistant:devfrom
bieniu:xiaomi_miio/led_brightness

Conversation

@bieniu
Copy link
Copy Markdown
Member

@bieniu bieniu commented Nov 22, 2021

Breaking change

Proposed change

This PR adds LED brightness entity (number platform) for ZA5 fan.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

This pull request needs to be manually signed off by @home-assistant/core before it can get merged.
(message by ReviewEnforcer)

@probot-home-assistant
Copy link
Copy Markdown

Hey there @rytilahti, @syssi, @starkillerOG, mind taking a look at this pull request as it has been labeled with an integration (xiaomi_miio) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Comment thread homeassistant/components/xiaomi_miio/number.py Outdated
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Would be good to follow up separately and remove the similar OscillationAngleValues modifications.

@frenck frenck merged commit 4649bc3 into home-assistant:dev Nov 23, 2021
@bieniu bieniu deleted the xiaomi_miio/led_brightness branch November 23, 2021 22:21
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants