Skip to content

Remove deprecated yaml config from flux_led#61844

Merged
bdraco merged 4 commits intohome-assistant:devfrom
tkdrob:flux_led_yaml
Dec 19, 2021
Merged

Remove deprecated yaml config from flux_led#61844
bdraco merged 4 commits intohome-assistant:devfrom
tkdrob:flux_led_yaml

Conversation

@tkdrob
Copy link
Copy Markdown
Contributor

@tkdrob tkdrob commented Dec 15, 2021

Breaking change

The previously deprecated YAML configuration of the Flux Led integration has been removed.

Flux Led is now configured via the UI, any existing YAML configuration has been imported in previous releases and can now be safely removed from your YAML configuration files.

Proposed change

Remove deprecated yaml config from flux_led

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @icemanch, mind taking a look at this pull request as it has been labeled with an integration (flux_led) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Dec 15, 2021

This is going to conflict heavily with these PRs
#61138
#61132

..and maybe this one
#61072

@tkdrob
Copy link
Copy Markdown
Contributor Author

tkdrob commented Dec 15, 2021

The previously deprecated YAML configuration of the Flux Led integration has been removed.

Flux Led is now configured via the UI, any existing YAML configuration has been imported in previous releases and can now be safely removed from your YAML configuration files.

I'll work on resolving the merge conflicts once you get these merged.

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Dec 19, 2021

@tkdrob I have a few more PRs for this, but the conflicts should be manageable now so any time you want move this forward works for me

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Dec 19, 2021

@tkdrob I figured I should fix the conflict since I was the one holding this up anyway.

Copy link
Copy Markdown
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tkdrob

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Dec 19, 2021

Tested ok 👍

@bdraco bdraco merged commit 1baba2a into home-assistant:dev Dec 19, 2021
@tkdrob tkdrob deleted the flux_led_yaml branch December 19, 2021 21:24
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants