Skip to content

Add zones support to flux_led#61072

Merged
frenck merged 1 commit intohome-assistant:devfrom
bdraco:flux_led_zones
Dec 20, 2021
Merged

Add zones support to flux_led#61072
frenck merged 1 commit intohome-assistant:devfrom
bdraco:flux_led_zones

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Dec 5, 2021

Proposed change

Add zones support to flux_led

The Addressable v3 (0xA3) models allow setting a color effect per zone. The length of each zone is the number of pixels per segment divided by the number of colors.

Service data attribute Description
entity_id The entity_id of the LED light to set the effect on.
colors List of colors for each zone (RGB). (Max 2048 Colors)
speed_pct The speed of the effect in % (0-100. Default 50)
effect The effect you would like. Valid options are static, running_water, strobe, jump, or breathing. (Default static)

Example

service: flux_led.set_zones
target:
  entity_id:
    - light.addressable_v3_8e2f7f
    - light.addressable_v3_8ebdeb
data:
  colors:
    - - 255
      - 0
      - 0
    - - 0
      - 255
      - 0
    - - 0
      - 0
      - 255
    - - 255
      - 255
      - 255
  speed_pct: 80
  effect: running_water

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @icemanch, mind taking a look at this pull request as it has been labeled with an integration (flux_led) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

bdraco added a commit to home-assistant/home-assistant.io that referenced this pull request Dec 5, 2021
@bdraco bdraco marked this pull request as ready for review December 6, 2021 02:36
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Dec 6, 2021
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Dec 19, 2021

rebase for conflicts only

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Dec 19, 2021

rebase for conflicts only

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bdraco 👍

@frenck frenck merged commit abc7dcf into home-assistant:dev Dec 20, 2021
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Dec 20, 2021

Thanks. That unblocks a few more 👍

@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed has-tests integration: flux_led smash Indicator this PR is close to finish for merging or closing