Skip to content

Add support for enabling/disabling cloud access in flux_led#61138

Merged
bdraco merged 43 commits intohome-assistant:devfrom
bdraco:flux_led_minor_version
Dec 19, 2021
Merged

Add support for enabling/disabling cloud access in flux_led#61138
bdraco merged 43 commits intohome-assistant:devfrom
bdraco:flux_led_minor_version

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Dec 7, 2021

Proposed change

A switch is now available to disconnect (or reconnect) the device from the cloud.

We now store the minor version and report it. This ensures we reload the config
entry when discovery sees the version change so the device keeps working.

Changelog: lightinglibs/flux_led@0.26.15...0.27.8

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @icemanch, mind taking a look at this pull request as it has been labeled with an integration (flux_led) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@bdraco bdraco closed this Dec 7, 2021
@bdraco bdraco reopened this Dec 7, 2021
@bdraco bdraco force-pushed the flux_led_minor_version branch from b9a79bf to e0780b1 Compare December 7, 2021 06:31
@bdraco bdraco marked this pull request as ready for review December 8, 2021 01:32
@bdraco bdraco added smash Indicator this PR is close to finish for merging or closing and removed smash Indicator this PR is close to finish for merging or closing labels Dec 11, 2021
@bdraco bdraco marked this pull request as draft December 11, 2021 21:06
@bdraco bdraco force-pushed the flux_led_minor_version branch from f8d88d5 to c8a33c2 Compare December 11, 2021 21:17
@bdraco bdraco changed the title Ensure flux_led reloads the integration after software update Add support for enabling/disabling cloud access in flux_led Dec 11, 2021
@bdraco bdraco marked this pull request as ready for review December 12, 2021 01:09
@bdraco bdraco added the smash Indicator this PR is close to finish for merging or closing label Dec 15, 2021
@bdraco bdraco force-pushed the flux_led_minor_version branch from feac6f3 to 0b5bde0 Compare December 16, 2021 11:30
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Dec 18, 2021

no changes, just keeping the lib in sync so it doesn't conflict with other PRs

@bdraco bdraco force-pushed the flux_led_minor_version branch from 8fa796e to 393afa2 Compare December 19, 2021 06:03
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Dec 19, 2021

almost got the conflicts unraveled

bdraco and others added 2 commits December 19, 2021 00:45
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Dec 19, 2021

Thanks. This one unblocks a lot of other work 👍

@bdraco bdraco merged commit a6b680c into home-assistant:dev Dec 19, 2021
@bdraco bdraco deleted the flux_led_minor_version branch December 19, 2021 06:59
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed has-tests integration: flux_led smash Indicator this PR is close to finish for merging or closing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants