Skip to content

Enable warnings for ZeroconfServiceInfo#60759

Merged
bdraco merged 1 commit intohome-assistant:devfrom
epenet:zeroconf-warnings
Dec 1, 2021
Merged

Enable warnings for ZeroconfServiceInfo#60759
bdraco merged 1 commit intohome-assistant:devfrom
epenet:zeroconf-warnings

Conversation

@epenet
Copy link
Copy Markdown
Contributor

@epenet epenet commented Dec 1, 2021

Breaking change

Enable warnings for ZeroconfServiceInfo

Linked to #60540

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration (zeroconf) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@bdraco bdraco marked this pull request as draft December 1, 2021 15:44
@bdraco
Copy link
Copy Markdown
Member

bdraco commented Dec 1, 2021

Marking this as a draft until #60629 is sorted

@epenet
Copy link
Copy Markdown
Contributor Author

epenet commented Dec 1, 2021

@bdraco if you take a look at this comment #60629 (comment) you will see that #60629 is not blocking.

@bdraco bdraco marked this pull request as ready for review December 1, 2021 15:55
@bdraco bdraco merged commit 683eb10 into home-assistant:dev Dec 1, 2021
@epenet epenet deleted the zeroconf-warnings branch December 1, 2021 15:56
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants