Use UsbServiceInfo in zwave_js

[epenet]

Proposed change

Use UsbServiceInfo (and corresponding constants) in zwave-js.

See home-assistant/architecture#662

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• [] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[probot-home-assistant]

Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration (zwave_js) you are listed as a code owner for? Thanks!
_{^{(message by CodeOwnersMention)}}

[epenet]

This is marked as draft due to the use of usb constants, and this architecture discussion : home-assistant/architecture#662 (comment)

[MartinHjelmare]

We don't need to open PRs if there's still something not resolved in the architecture discussion. Do you want to have some input now in this PR?

[epenet]

The constants have already been merged in #60086, so I am just waiting for confirmation from @bdraco that we will not revert that PR.

[epenet]

This looked like dead code when I amended it - I couldn't find references to NORTEK_ZIGBEE_DISCOVERY_INFO
Should it be removed instead of amended?

[MartinHjelmare]

Still, if you're waiting for confirmation, you can also wait with opening the PR. Draft PRs that don't want input are just spam.

[epenet]

@MartinHjelmare do you agree that NORTEK_ZIGBEE_DISCOVERY_INFO is dead code and should be removed?
Do you approve the migration to UsbServiceInfo in the tests?

Also, if the usb constants are kept, do you approve their use in zwave_js?

[MartinHjelmare]

Yes, if we don't use a constant we can remove it.

Yes, I approve the use in zwave_js if we decide to go with that application wide.

[bdraco]

closing via #60137

[epenet]

Will reopen after #60140 is merged