Skip to content

Revert "Create new usb constants (#60086)"#60137

Merged
bdraco merged 1 commit intohome-assistant:devfrom
epenet:revert-usb-constants
Nov 22, 2021
Merged

Revert "Create new usb constants (#60086)"#60137
bdraco merged 1 commit intohome-assistant:devfrom
epenet:revert-usb-constants

Conversation

@epenet
Copy link
Copy Markdown
Contributor

@epenet epenet commented Nov 22, 2021

Breaking change

None, if this is merged before 2021.12.

Proposed change

Revert "Create new usb constants (#60086)"
This reverts commit 263101b.

If we use a dataclass instead of a TypedDict, then this is not required.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Loading
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants