Conversation
|
Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( |
|
Hey there @tkdrob, mind taking a look at this pull request as it has been labeled with an integration ( |
|
I have taken out the "ATTR_DEVICE" constant as @frenck would say it is dead code (until another component needs it). Should I use the constants in the new_usb = [
{"domain": "test1", "vid": "3039", "pid": "3039", "description": "*2652*"}
]vs new_usb = [
{"domain": "test1", usb.ATTR_VID: "3039", usb.ATTR_PID: "3039", usb.ATTR_DESCRIPTION: "*2652*"}
] |
|
Actually let's leave |
This reverts commit 263101b.
Breaking change
Create usb constants.
As requested by @bdraco in #60042
Proposed change
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: