Skip to content

Create new usb constants#60086

Merged
bdraco merged 4 commits intohome-assistant:devfrom
epenet:modem-callerid-attributes
Nov 22, 2021
Merged

Create new usb constants#60086
bdraco merged 4 commits intohome-assistant:devfrom
epenet:modem-callerid-attributes

Conversation

@epenet
Copy link
Copy Markdown
Contributor

@epenet epenet commented Nov 21, 2021

Breaking change

Create usb constants.

As requested by @bdraco in #60042

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration (usb) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link
Copy Markdown

Hey there @tkdrob, mind taking a look at this pull request as it has been labeled with an integration (modem_callerid) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@epenet epenet changed the title Use usb constants in modem_callerid Create usb constants in modem_callerid Nov 21, 2021
@epenet epenet changed the title Create usb constants in modem_callerid Use usb constants in modem_callerid Nov 21, 2021
@epenet epenet changed the title Use usb constants in modem_callerid Create new usb constants Nov 21, 2021
@epenet
Copy link
Copy Markdown
Contributor Author

epenet commented Nov 21, 2021

I have taken out the "ATTR_DEVICE" constant as @frenck would say it is dead code (until another component needs it).
I will re-add it in the modem_callerid PR #60042.

Should I use the constants in the new_usb variables? new_usb is a mock from async_get_usb which comes from loader.py so I decided to keep them separate, but I can update the tests if you request it.

     new_usb = [
        {"domain": "test1", "vid": "3039", "pid": "3039", "description": "*2652*"}
    ]

vs

     new_usb = [
        {"domain": "test1", usb.ATTR_VID: "3039", usb.ATTR_PID: "3039", usb.ATTR_DESCRIPTION: "*2652*"}
    ]

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Nov 21, 2021

Actually let's leave ATTR_DEVICE in here so we don't have changes to two integrations in the same PR if we can avoid it

@bdraco bdraco marked this pull request as draft November 21, 2021 21:41
@epenet epenet marked this pull request as ready for review November 21, 2021 21:47
@bdraco bdraco merged commit 263101b into home-assistant:dev Nov 22, 2021
@epenet epenet deleted the modem-callerid-attributes branch November 22, 2021 06:40
@epenet epenet mentioned this pull request Nov 22, 2021
21 tasks
epenet added a commit to epenet/home-assistant-core that referenced this pull request Nov 22, 2021
bdraco pushed a commit that referenced this pull request Nov 22, 2021
Co-authored-by: epenet <epenet@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants