Adjust async_step_homekit signature for strict typing#59745
Merged
bdraco merged 3 commits intohome-assistant:devfrom Nov 15, 2021
Merged
Adjust async_step_homekit signature for strict typing#59745bdraco merged 3 commits intohome-assistant:devfrom
bdraco merged 3 commits intohome-assistant:devfrom
Conversation
|
Hey there @milanmeu, mind taking a look at this pull request as it has been labeled with an integration ( |
|
Hey there @bachya, mind taking a look at this pull request as it has been labeled with an integration ( |
|
Hey there @janiversen, mind taking a look at this pull request as it has been labeled with an integration ( |
bdraco
approved these changes
Nov 15, 2021
bachya
approved these changes
Nov 15, 2021
This was referenced Nov 15, 2021
Member
|
Test failure is unrelated and fixed in #59749 |
22 tasks
This was referenced Nov 16, 2021
natekspencer
pushed a commit
to natekspencer/home-assistant-core
that referenced
this pull request
Nov 16, 2021
…#59745) * Use ZeroconfServiceInfo in async_step_homekit * Update DiscoveryFlowHandler * Update components
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Adjust async_step_homekit type hint, as follow-up to #59503
See home-assistant/architecture#662
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: