Use ZeroconfServiceInfo in gogogate2

[epenet]

Proposed change

Use ZeroconfServiceInfo in gogogate2

Followup to #59745

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[probot-home-assistant]

Hey there @vangorra, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (gogogate2) you are listed as a code owner for? Thanks!
_{^{(message by CodeOwnersMention)}}

[epenet]

Note: needs rebase after #59745 is merged

[epenet]

Rebased now #59745 is merged

[bdraco]

Should we add a constant for id since its a defined field for homekit?

[epenet]

id is harder to pinpoint with grep, but I had a quick scan of the components and there does seem to be a few components using it. Should I add ATTR_PROPERTIES_ID constant to zeroconf?
It's a bit long, and I could add ATTR_ID but I am worried about adding confusion with the base attributes.

[epenet]

Or maybe you want me to add the constant to homekit?

[bdraco]

HomeKit discovery is a subset of zeroconf discovery. I think you have it in the right place.

I hate to ask for a one line change, but It really should be a separate PR.

[epenet]

I thought you wanted it in this PR... I have reverted it now.

[epenet]

Note: CI failed due to a flaky test in tado and do not fail locally

[bdraco]

That or ATTR_HOMEKIT_PROPERTIES_ID, ATTR_HOMEKIT_ID. Its the same regardless if its homekit or not so maybe ATTR_PROPERTIES_ID is the best choice. Naming is hard.

…

On Nov 16, 2021, at 00:37, epenet ***@***.***> wrote: @epenet commented on this pull request. In homeassistant/components/gogogate2/config_flow.py <#59746 (comment)>: > """Handle homekit discovery.""" - await self.async_set_unique_id(discovery_info["properties"]["id"]) - return await self._async_discovery_handler(discovery_info["host"]) + await self.async_set_unique_id(discovery_info[zeroconf.ATTR_PROPERTIES]["id"]) id is harder to pinpoint with grep, but I had a quick scan of the components and there does seem to be a few components using it. Should I add ATTR_PROPERTIES_ID constant to zeroconf? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#59746 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFB7CEEWI36F3TWEE6VUWDUMH34DANCNFSM5ICUZCCQ>.

[epenet]

Rebased to re-trigger CI following #59787

[epenet]

Note: CI is failing just because of codecov/patch