Skip to content

Adjust async_step_dhcp signature for strict typing#59751

Merged
frenck merged 5 commits intohome-assistant:devfrom
epenet:dhcp-service-info
Nov 16, 2021
Merged

Adjust async_step_dhcp signature for strict typing#59751
frenck merged 5 commits intohome-assistant:devfrom
epenet:dhcp-service-info

Conversation

@epenet
Copy link
Copy Markdown
Contributor

@epenet epenet commented Nov 15, 2021

Proposed change

Adjust async_step_dhcp signature for strict typing, as follow-up to #59503 and #59745

See home-assistant/architecture#662

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration (dhcp) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@epenet
Copy link
Copy Markdown
Contributor Author

epenet commented Nov 15, 2021

Note: needs rebase after #59745 is merged

@epenet epenet marked this pull request as ready for review November 16, 2021 05:36
@epenet epenet requested review from a team and bdraco as code owners November 16, 2021 05:36
@epenet
Copy link
Copy Markdown
Contributor Author

epenet commented Nov 16, 2021

Rebased now #59745 is merged

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Nov 16, 2021

Looks like there are a couple places that mypy isn't happy with as well

@frenck frenck merged commit 476a59d into home-assistant:dev Nov 16, 2021
@epenet epenet deleted the dhcp-service-info branch November 16, 2021 11:21
natekspencer pushed a commit to natekspencer/home-assistant-core that referenced this pull request Nov 16, 2021
)

Co-authored-by: epenet <epenet@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants