Skip to content

Velbus typing part 2#59148

Merged
farmio merged 5 commits intohome-assistant:devfrom
cereal2nd:velbusTyping2
Nov 11, 2021
Merged

Velbus typing part 2#59148
farmio merged 5 commits intohome-assistant:devfrom
cereal2nd:velbusTyping2

Conversation

@cereal2nd
Copy link
Copy Markdown
Contributor

@cereal2nd cereal2nd commented Nov 5, 2021

Proposed change

Finish adding typing info to the integration

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @brefra, mind taking a look at this pull request as it has been labeled with an integration (velbus) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Copy link
Copy Markdown
Member

@farmio farmio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Consider adding homeassistant.components.velbus.* to https://github.com/home-assistant/core/blob/dev/.strict-typing

@cereal2nd
Copy link
Copy Markdown
Contributor Author

The device_info ignore is needed until #58622 is merged

@farmio
Copy link
Copy Markdown
Member

farmio commented Nov 6, 2021

To avoid casting everything coming from velbusaio you can have a look at https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-type-hints-for-third-party-library
Since it has return types defined it comes down to adding a py.typed file and probably fixing some annotations in the lib.

@cereal2nd
Copy link
Copy Markdown
Contributor Author

all errors should be fixed once #59353 is merged

@MartinHjelmare
Copy link
Copy Markdown
Member

We can rebase here now.

@farmio farmio merged commit 6a21b24 into home-assistant:dev Nov 11, 2021
@cereal2nd cereal2nd deleted the velbusTyping2 branch November 11, 2021 12:53
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants