Skip to content

Use zeroconf HaServiceInfo in tests (A-D)#58836

Merged
bdraco merged 3 commits intohome-assistant:devfrom
epenet:zeronconf-test-a-d
Nov 2, 2021
Merged

Use zeroconf HaServiceInfo in tests (A-D)#58836
bdraco merged 3 commits intohome-assistant:devfrom
epenet:zeronconf-test-a-d

Conversation

@epenet
Copy link
Copy Markdown
Contributor

@epenet epenet commented Oct 31, 2021

Proposed change

Use zeroconf HaServiceInfo in tests (A-D)
Follow-up to #58835

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @postlund, mind taking a look at this pull request as it has been labeled with an integration (apple_tv) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@epenet epenet mentioned this pull request Oct 31, 2021
22 tasks
@epenet epenet marked this pull request as ready for review October 31, 2021 19:46
@epenet epenet changed the title Use zeroconf attributes in tests (A-D) Use zeroconf HaServiceInfo in tests (A-D) Oct 31, 2021
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Oct 31, 2021
Copy link
Copy Markdown
Member

@Kane610 Kane610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to Axis tests looks good!

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Nov 2, 2021

Please see comment here

#58835 (comment)

@bdraco bdraco merged commit 2b22d63 into home-assistant:dev Nov 2, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2021
@epenet epenet deleted the zeronconf-test-a-d branch November 16, 2021 11:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed code-quality Hacktoberfest hacktoberfest-accepted has-tests integration: apple_tv small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants