Skip to content

Use ZeroconfServiceInfo in bosch_shc#58957

Merged
frenck merged 3 commits intohome-assistant:devfrom
epenet:zeroconf-bosch
Nov 16, 2021
Merged

Use ZeroconfServiceInfo in bosch_shc#58957
frenck merged 3 commits intohome-assistant:devfrom
epenet:zeroconf-bosch

Conversation

@epenet
Copy link
Copy Markdown
Contributor

@epenet epenet commented Nov 2, 2021

Proposed change

Add type hint to bosch-shc zeroconf discovery (missed in #58835)

Follow-up to #59503

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @tschamm, mind taking a look at this pull request as it has been labeled with an integration (bosch_shc) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@epenet epenet changed the title Add type hint to zeroconf discovery Add type hint to bosch zeroconf discovery Nov 2, 2021
@epenet epenet changed the title Add type hint to bosch zeroconf discovery Add type hint to bosch-shc zeroconf discovery Nov 2, 2021
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Nov 3, 2021
Copy link
Copy Markdown
Contributor

@garbled1 garbled1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frenck frenck removed the smash Indicator this PR is close to finish for merging or closing label Nov 14, 2021
@epenet
Copy link
Copy Markdown
Contributor Author

epenet commented Nov 14, 2021

Marking as draft until #59503 is merged

@epenet epenet marked this pull request as draft November 14, 2021 20:20
@epenet
Copy link
Copy Markdown
Contributor Author

epenet commented Nov 15, 2021

Rebased following merge of #59503

@epenet epenet marked this pull request as ready for review November 15, 2021 18:39
@epenet epenet changed the title Add type hint to bosch-shc zeroconf discovery Use ZeroconfServiceInfo in bosch-shc Nov 15, 2021
@tschamm
Copy link
Copy Markdown
Contributor

tschamm commented Nov 15, 2021

Can you rename the title of the PR to Use ZeroconfServiceInfo in bosch_shc?

@epenet epenet changed the title Use ZeroconfServiceInfo in bosch-shc Use ZeroconfServiceInfo in bosch_shc Nov 15, 2021
@epenet
Copy link
Copy Markdown
Contributor Author

epenet commented Nov 15, 2021

@tschamm done

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @epenet 👍

@frenck frenck merged commit cca3cdb into home-assistant:dev Nov 16, 2021
@epenet epenet deleted the zeroconf-bosch branch November 16, 2021 10:47
natekspencer pushed a commit to natekspencer/home-assistant-core that referenced this pull request Nov 16, 2021
Co-authored-by: epenet <epenet@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants