Use ZeroconfServiceInfo in bosch_shc#58957
Merged
frenck merged 3 commits intohome-assistant:devfrom Nov 16, 2021
Merged
Conversation
|
Hey there @tschamm, mind taking a look at this pull request as it has been labeled with an integration ( |
frenck
requested changes
Nov 14, 2021
Contributor
Author
|
Marking as draft until #59503 is merged |
d37879b to
62d6a3c
Compare
Contributor
Author
|
Rebased following merge of #59503 |
Contributor
|
Can you rename the title of the PR to |
Contributor
Author
|
@tschamm done |
frenck
approved these changes
Nov 16, 2021
natekspencer
pushed a commit
to natekspencer/home-assistant-core
that referenced
this pull request
Nov 16, 2021
Co-authored-by: epenet <epenet@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Add type hint to bosch-shc zeroconf discovery (missed in #58835)
Follow-up to #59503
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: