More face attributes for microsoft_face_detect API#51028
More face attributes for microsoft_face_detect API#51028gonzalezcalleja wants to merge 8 commits intohome-assistant:devfrom
Conversation
Merge Changes
Bumps [actions/setup-python](https://github.com/actions/setup-python) from v2.2.1 to v2.2.2. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v2.2.1...dc73133) Signed-off-by: dependabot[bot] <support@github.com>
…actions/setup-python-v2.2.2 Bump actions/setup-python from v2.2.1 to v2.2.2
Sync repo
|
Shouldn't these constants be used somehow? |
If you did't declare it in image_processing.microsoft_face_detect, you can't use it in the config:
|
|
Please format your code with black and isort. |
|
These are string specific to this API? It is not clear that sharing these string constants with a common library is worthwhile since the strings are specific to the microsoft API. |
| ATTR_FACES = "faces" | ||
| ATTR_GENDER = "gender" | ||
| ATTR_GLASSES = "glasses" | ||
| ATTR_HAIR = "hair" |
There was a problem hiding this comment.
I agree, these should not be added to default integration. Add to microsoft integration instead.
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Breaking change
Proposed change
The actual component microsoft_face_detect are only using a few face attributes from Microsoft Face API, could be useful to add some other to the component.
In this PR I'm adding this face attributes:
https://westus.dev.cognitive.microsoft.com/docs/services/563879b61984550e40cbbe8d/operations/563879b61984550f30395236
Type of change
Example entry for
configuration.yaml:Additional information
Doc for PR 51028 home-assistant.io#18429Doc for PR 51028 home-assistant.io#19075Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: