Skip to content

Doc for PR 51028#18429

Closed
gonzalezcalleja wants to merge 166 commits into
home-assistant:nextfrom
gonzalezcalleja:patch-1
Closed

Doc for PR 51028#18429
gonzalezcalleja wants to merge 166 commits into
home-assistant:nextfrom
gonzalezcalleja:patch-1

Conversation

@gonzalezcalleja
Copy link
Copy Markdown
Contributor

@gonzalezcalleja gonzalezcalleja commented Jul 8, 2021

Doc for home-assistant/core#51028, more face attributes for microsoft_face_detect API

Proposed change

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue:

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Doc for PR #51028, more face attributes for microsoft_face_detect API
@probot-home-assistant probot-home-assistant Bot added the current This PR goes into the current branch label Jul 8, 2021
@probot-home-assistant probot-home-assistant Bot added has-parent This PR has a parent PR in another repo in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Jul 8, 2021
@probot-home-assistant
Copy link
Copy Markdown

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.
(message by DocsTargetBranch)

@gonzalezcalleja gonzalezcalleja changed the base branch from current to next July 10, 2021 10:17
frenck and others added 20 commits July 28, 2021 22:28
Corrected wrong template name example.
The stated Annke NVR is also confirmed working. As reference check this article - https://peyanski.com/annke-c800-annke-nvr-home-assistant-integration/
Bumps [ruby/setup-ruby](https://github.com/ruby/setup-ruby) from 1.78.0 to 1.79.0.
- [Release notes](https://github.com/ruby/setup-ruby/releases)
- [Commits](ruby/setup-ruby@v1.78.0...v1.79.0)

---
updated-dependencies:
- dependency-name: ruby/setup-ruby
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Not actually sure if it's a doc or code bug, but "traces:" is refused while "trace:" works
Co-authored-by: Joakim Sørensen <joasoe@gmail.com>
Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Document zwave_js.meter_reset service

* revert additional change and put in separate PR

* Updates based on PR feedback

* Tweak

* tweaks based on upstream feedback

Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@thecode
Copy link
Copy Markdown
Member

thecode commented Aug 24, 2021

Hi @gonzalezcalleja,
I suggest to close this PR, make sure you rebase your branch to next and make a new PR

@gonzalezcalleja
Copy link
Copy Markdown
Contributor Author

Hi @gonzalezcalleja,
I suggest to close this PR, make sure you rebase your branch to next and make a new PR

Thanks for your support and sorry for this bad PR, this is the new PR #19075.

@probot-home-assistant probot-home-assistant Bot removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch in-progress This PR/Issue is currently being worked on labels Aug 24, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed has-parent This PR has a parent PR in another repo next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.