Skip to content

More face attributes for microsoft_face_detect API #51028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gonzalezcalleja wants to merge 8 commits into from
Closed

More face attributes for microsoft_face_detect API #51028

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
68aad34
Merge pull request #1 from home-assistant/dev
gonzalezcalleja Jun 12, 2019
b0c1c8d
Merge branch 'master' of https://github.com/home-assistant/core into dev
gonzalezcalleja Apr 16, 2021
fc1326b
Bump actions/setup-python from v2.2.1 to v2.2.2
dependabot[bot] Apr 19, 2021
dcea442
Merge pull request #5 from gonzalezcalleja/dependabot/github_actions/…
gonzalezcalleja Apr 19, 2021
7e581f8
Merge pull request #13 from home-assistant/dev
gonzalezcalleja May 24, 2021
79e5d3a
Adding more attributes for Microsoft Face Detect API
gonzalezcalleja May 24, 2021
b028342
Added new attibutes in SUPPORTED_ATTRIBUTES
gonzalezcalleja Jun 20, 2021
26d1d66
Format code with isort / black
gonzalezcalleja Jul 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions homeassistant/components/image_processing/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,11 @@
ATTR_FACES = "faces"
ATTR_GENDER = "gender"
ATTR_GLASSES = "glasses"
ATTR_HAIR = "hair"
Copy link
Copy Markdown
Member

@balloob balloob Dec 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, these should not be added to default integration. Add to microsoft integration instead.

ATTR_SMILE = "smile"
ATTR_FACIALHAIR = "facialhair"
ATTR_EMOTION = "emotion"
ATTR_ACCESSORIES = "accessories"
ATTR_MOTION = "motion"
ATTR_TOTAL_FACES = "total_faces"

Expand Down
16 changes: 15 additions & 1 deletion homeassistant/components/microsoft_face_detect/image_processing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,14 @@
import voluptuous as vol

from homeassistant.components.image_processing import (
ATTR_ACCESSORIES,
ATTR_AGE,
ATTR_EMOTION,
ATTR_FACIALHAIR,
ATTR_GENDER,
ATTR_GLASSES,
ATTR_HAIR,
ATTR_SMILE,
CONF_ENTITY_ID,
CONF_NAME,
CONF_SOURCE,
Expand All @@ -20,7 +25,16 @@

_LOGGER = logging.getLogger(__name__)

SUPPORTED_ATTRIBUTES = [ATTR_AGE, ATTR_GENDER, ATTR_GLASSES]
SUPPORTED_ATTRIBUTES = [
ATTR_AGE,
ATTR_GENDER,
ATTR_GLASSES,
ATTR_HAIR,
ATTR_SMILE,
ATTR_FACIALHAIR,
ATTR_EMOTION,
ATTR_ACCESSORIES,
]

CONF_ATTRIBUTES = "attributes"
DEFAULT_ATTRIBUTES = [ATTR_AGE, ATTR_GENDER]
Expand Down