Skip to content

Don't combine old and new value on scene update#49248

Merged
bramkragten merged 2 commits intodevfrom
fix-removing-key-from-scene
Apr 26, 2021
Merged

Don't combine old and new value on scene update#49248
bramkragten merged 2 commits intodevfrom
fix-removing-key-from-scene

Conversation

@bramkragten
Copy link
Copy Markdown
Member

Proposed change

When you would remove a key from the scene config in the UI, it would be merged back in, in the backend. This solves that, the new config is always the complete config and not a partial one. So no need to merge with the old value.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Copy link
Copy Markdown
Member

@spacegaier spacegaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed it fixes the issue.

@bramkragten bramkragten merged commit 9e7d83b into dev Apr 26, 2021
@bramkragten bramkragten deleted the fix-removing-key-from-scene branch April 26, 2021 21:38
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants