Skip to content

Fix activate scene button + allow removing icon#8916

Merged
bramkragten merged 2 commits intodevfrom
fix-activate-scene
Apr 15, 2021
Merged

Fix activate scene button + allow removing icon#8916
bramkragten merged 2 commits intodevfrom
fix-activate-scene

Conversation

@bramkragten
Copy link
Copy Markdown
Member

@bramkragten bramkragten commented Apr 14, 2021

Fixes #8907
Fixes #7877

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten changed the title Fix activate scene button Fix activate scene button + allow removing icon Apr 14, 2021
Copy link
Copy Markdown
Member

@spacegaier spacegaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scene play fix works for me. But the coding for the icon saving does not. It now allows to press the save button when you empty the icon field (the delete statement does its job), but the previous icon stays nonetheless (if you go back to the overview it is there and when you go into scene editing again, it is filled again).

Once we have a solution for that, the same fix also needs to be copied to ha-script-editor I think.

@bramkragten
Copy link
Copy Markdown
Member Author

Mmm that sounds like a backend issue then...

@bramkragten
Copy link
Copy Markdown
Member Author

@spacegaier
Copy link
Copy Markdown
Member

home-assistant/core#49248

Fixes the issue for scenes, but issue still remains for scripts (I copied over the frontend fix and then the frontend allows saving, but the backend still seems to retain the old value).

@bramkragten
Copy link
Copy Markdown
Member Author

Well this issue / pr is for scenes, scripts can be a separate one :-)

@bramkragten bramkragten merged commit 8e11aa9 into dev Apr 15, 2021
@bramkragten bramkragten deleted the fix-activate-scene branch April 15, 2021 11:02
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to trigger scenes using 'play' icon in Configuration → Scenes Error removing custom icon in scene editor

3 participants