Skip to content

Don't combine old and new value on scene update #49248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bramkragten merged 2 commits into from
Apr 26, 2021
Merged

Don't combine old and new value on scene update #49248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ef3988
Don't combine old and new value on scene update
bramkragten Apr 15, 2021
a021e1f
Update script config write
bramkragten Apr 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions homeassistant/components/config/scene.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,13 +66,11 @@ def _write_value(self, hass, data, config_key, new_value):
# Iterate through some keys that we want to have ordered in the output
updated_value = OrderedDict()
for key in ("id", "name", "entities"):
if key in cur_value:
updated_value[key] = cur_value[key]
if key in new_value:
updated_value[key] = new_value[key]

# We cover all current fields above, but just in case we start
# supporting more fields in the future.
updated_value.update(cur_value)
updated_value.update(new_value)

data[index] = updated_value
10 changes: 9 additions & 1 deletion homeassistant/components/config/script.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ async def hook(action, config_key):
await hass.services.async_call(DOMAIN, SERVICE_RELOAD)

hass.http.register_view(
EditKeyBasedConfigView(
EditScriptConfigView(
DOMAIN,
"config",
SCRIPT_CONFIG_PATH,
Expand All @@ -27,3 +27,11 @@ async def hook(action, config_key):
)
)
return True


class EditScriptConfigView(EditKeyBasedConfigView):
"""Edit script config."""

def _write_value(self, hass, data, config_key, new_value):
"""Set value."""
data[config_key] = new_value