Skip to content

Prevent config entry retry from blocking startup#48660

Merged
balloob merged 1 commit into
home-assistant:devfrom
bdraco:retry_block_startup
Apr 4, 2021
Merged

Prevent config entry retry from blocking startup#48660
balloob merged 1 commit into
home-assistant:devfrom
bdraco:retry_block_startup

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Apr 3, 2021

Proposed change

Prevent config entry retry from blocking startup

  • If there are two integrations doing long retries async_block_till_done() will never be done

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

- If there are two integrations doing long retries async_block_till_done() will never be done
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Apr 3, 2021

PlatformNotReady has the same concern

It could probably benefit from the same changes as #48449 and #47201

@bdraco bdraco marked this pull request as ready for review April 3, 2021 22:41
@bdraco bdraco added this to the 2021.4.0 milestone Apr 3, 2021
Copy link
Copy Markdown
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@balloob balloob merged commit cfe2df9 into home-assistant:dev Apr 4, 2021
balloob pushed a commit that referenced this pull request Apr 4, 2021
- If there are two integrations doing long retries async_block_till_done() will never be done
bdraco added a commit to bdraco/home-assistant that referenced this pull request Apr 4, 2021
MartinHjelmare pushed a commit that referenced this pull request Apr 4, 2021
* Apply ConfigEntryNotReady improvements to PlatformNotReady

- Limit log spam #47201
- Log exception reason #48449
- Prevent startup blockage #48660

* coverage
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Startup can block until timeout if multiple integrations are doing long setup retries

3 participants