Limit log spam by ConfigEntryNotReady#47201
Conversation
| self.domain, | ||
| wait_time, | ||
| ) | ||
| if wait_time < 80: |
There was a problem hiding this comment.
Maybe just log a warning the first time, and let the rest be debug messages?
There was a problem hiding this comment.
I like the suggestion.
Should I word it
"Config entry '%s' for %s integration not ready yet. Retrying in background"
or something similar ?
There was a problem hiding this comment.
In the mean time that we wait for Paulus check, I'll updated the code.
frenck
left a comment
There was a problem hiding this comment.
I think this makes sense, so approving to support it 👍
|
Yeah, this is good. Maybe you can adjust |
|
@amelchio let's do that in another PR. Btw surprised ESPHome is using PlatformNotReady 🤔 |
|
My bad, ESPHome actually has its own retry logic. I have submitted #47456 to limit it. |
Proposed change
Some movable devices, like Plug, can be switched off during HA restart.
This will spam the log every 80sec.
This PR will limit to the first 80sec the logging, still leaving the retry every 80sec.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: