Log the reason a config entry failed to setup#48449
Merged
MartinHjelmare merged 1 commit intohome-assistant:devfrom Mar 29, 2021
Merged
Log the reason a config entry failed to setup#48449MartinHjelmare merged 1 commit intohome-assistant:devfrom
MartinHjelmare merged 1 commit intohome-assistant:devfrom
Conversation
If we pass a string to ConfigEntryNotReady or raise it from another exception we now log the string passed or the string generated by the original exception. With home-assistant#47201 this makes it easy for developers to still show the reason why setup failed without having to worry about log spam from additional attempts by rasing ConfigEntryNotReady from the original exception.
bdraco
added a commit
to bdraco/home-assistant
that referenced
this pull request
Mar 28, 2021
…late Also when coupled with home-assistant#48449, log spam is reduced since we do not log an additional failure each resetup attempt.
21 tasks
bdraco
added a commit
to bdraco/home-assistant
that referenced
this pull request
Mar 29, 2021
…late Also when coupled with home-assistant#48449, log spam is reduced since we do not log an additional failure each resetup attempt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Log the reason a config entry failed to setup
If we pass a string to ConfigEntryNotReady or raise it from
another exception we now log the string passed or the
string generated by the original exception.
With #47201 this makes it easy for developers to still show
the reason why setup failed without having to worry about log
spam from additional attempts by rasing ConfigEntryNotReady
from the original exception.
Example with
heosbelow:Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: