Create async_config_entry_first_refresh to reduce coordinator boilerplate#48451
Merged
bdraco merged 7 commits intohome-assistant:devfrom Mar 29, 2021
Merged
Create async_config_entry_first_refresh to reduce coordinator boilerplate#48451bdraco merged 7 commits intohome-assistant:devfrom
bdraco merged 7 commits intohome-assistant:devfrom
Conversation
Member
Author
|
Not 100% on the naming, but naming is hard. |
f616e02 to
bdbbaa5
Compare
Member
Author
|
Thank you! |
Member
|
We should update the example code in the dev docs too. |
Member
Author
|
I'll do the doc updates shortly. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Create async_config_entry_first_refresh to reduce coordinator boilerplate
Also when coupled with #48449, log spam is reduced since we do
not log an additional failure each re-setup attempt unless
debug logging is turned on.
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: