Skip to content

Add vicare fuelcell#47167

Merged
MartinHjelmare merged 2 commits intohome-assistant:devfrom
nbraem:feat/vicare_fuelcell
Mar 31, 2021
Merged

Add vicare fuelcell#47167
MartinHjelmare merged 2 commits intohome-assistant:devfrom
nbraem:feat/vicare_fuelcell

Conversation

@nbraem
Copy link
Copy Markdown
Contributor

@nbraem nbraem commented Feb 28, 2021

Breaking change

Proposed change

Add support for vicare fuelcell device type. Support for this device was added in PyViCare and is for the Viessmann VitoValor PT2, which is both a gaz boiler and a fuel cell which generates electricity.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
vicare:
  username: username
  password: password
  heating_type: fuelcell

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @nbraem,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant
Copy link
Copy Markdown

Hey there @oischinger, mind taking a look at this pull request as its been labeled with an integration (vicare) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Copy link
Copy Markdown
Contributor

@oischinger oischinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@nbraem
Copy link
Copy Markdown
Contributor Author

nbraem commented Mar 7, 2021

What needs to happen next?

@oischinger
Copy link
Copy Markdown
Contributor

I guess maintainers need to approve and merge it into dev

@raman325
Copy link
Copy Markdown
Contributor

raman325 commented Mar 8, 2021

@nbraem please submit a PR to update the docs as well and link to that PR here

@nbraem
Copy link
Copy Markdown
Contributor Author

nbraem commented Mar 8, 2021

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare MartinHjelmare merged commit 96857b7 into home-assistant:dev Mar 31, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants