Skip to content

add PyViCareFuelCell#45

Merged
somm15 merged 1 commit intoopenviess:masterfrom
nbraem:master
Dec 9, 2020
Merged

add PyViCareFuelCell#45
somm15 merged 1 commit intoopenviess:masterfrom
nbraem:master

Conversation

@nbraem
Copy link
Copy Markdown
Contributor

@nbraem nbraem commented Nov 1, 2020

Add new device class for the VitoValor PT2.
It inherits all properties from GazBoiler.

Add new device class for the VitoValor PT2.
It inherits all properties from GazBoiler.
@nbraem nbraem changed the title add PyVicareFuelCell add PyViCareFuelCell Nov 5, 2020
@somm15
Copy link
Copy Markdown
Collaborator

somm15 commented Nov 5, 2020

I don't really have a FuelCell so I can't check.
Are you sure your device has all the methods from the GazBoiler?
Should you inherit from Device instead?

@nbraem
Copy link
Copy Markdown
Contributor Author

nbraem commented Nov 9, 2020

Yes, the PT2 is a traditional gas boiler with a fuel cell. I tried all the methods from GazBoiler, they all work fine. If you want, I can share the complete json.

@somm15 somm15 merged commit 8fe7e32 into openviess:master Dec 9, 2020
@woehrl01
Copy link
Copy Markdown
Collaborator

woehrl01 commented Jan 3, 2021

@nbraem I just added some initial unit tests (see #55). It would be awesome if you could add and share your complete JSON, so we ensure that this works as expected in the future. If you don't have time you can send my the JSON, and I'll write some tests myself.

CFenner referenced this pull request in CFenner/PyViCare Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants