Skip to content

add vicare fuelcell heating_type#16920

Merged
frenck merged 1 commit intohome-assistant:nextfrom
nbraem:next-vicare-fuelcell
Mar 31, 2021
Merged

add vicare fuelcell heating_type#16920
frenck merged 1 commit intohome-assistant:nextfrom
nbraem:next-vicare-fuelcell

Conversation

@nbraem
Copy link
Copy Markdown
Contributor

@nbraem nbraem commented Mar 8, 2021

Proposed change

Document new vicare device type fuelcell. Support for this device was added in home-assistant/core#47167 and is for the Viessmann VitoValor PT2, which is both a gaz boiler and a fuel cell which generates electricity.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase: Add vicare fuelcell core#47167
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue:

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added the has-parent This PR has a parent PR in another repo label Mar 8, 2021
@probot-home-assistant probot-home-assistant Bot added the next This PR goes into the next branch label Mar 8, 2021
@nbraem nbraem mentioned this pull request Mar 8, 2021
21 tasks
@frenck frenck added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label Mar 8, 2021
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added the awaits-parent Awaits the merge of an parent PR label Mar 8, 2021
@MartinHjelmare MartinHjelmare added parent-merged The parent PR has been merged already and removed awaits-parent Awaits the merge of an parent PR labels Mar 31, 2021
@frenck frenck merged commit 7ec532b into home-assistant:next Mar 31, 2021
@probot-home-assistant probot-home-assistant Bot removed the parent-merged The parent PR has been merged already label Mar 31, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants