-
-
Notifications
You must be signed in to change notification settings - Fork 37.7k
Add services to SmartTub for changing filtration settings #46980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 24 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
8303fd9
WIP
mdz b5e84be
test passing
mdz 96f8498
add secondary filtration service
mdz affb2b2
add services.yaml
mdz 8c2a7fe
fix safeguard
mdz eb58497
ensure upcase
mdz 212825f
gen requirements
mdz 7d34403
fix validators
mdz 5e9fac6
Update homeassistant/components/smarttub/sensor.py
mdz 7cbc04a
Update homeassistant/components/smarttub/sensor.py
mdz dd59e3a
Update homeassistant/components/smarttub/sensor.py
mdz b0a1db6
Update homeassistant/components/smarttub/sensor.py
mdz 5046f9a
update services.yaml to new format
mdz 46bc01b
use make_entity_service_schema
mdz b795e84
simplify schema definition
mdz 2fd9f9e
WIP
mdz 4f7a76c
remove stray import
mdz 3d8ea27
Merge remote-tracking branch 'upstream/dev' into smarttub-filtration-…
mdz 6d67d9a
remove unused copypasta
mdz 976fbc7
filter entities by supported feature
mdz 3b79d85
mode is required
mdz 02cb31f
remove supported_features, doesn't work
mdz 0540618
Merge remote-tracking branch 'upstream/dev' into smarttub-filtration-…
mdz c0af0ea
Merge remote-tracking branch 'upstream/dev' into smarttub-filtration-…
mdz d3885ba
Merge remote-tracking branch 'upstream/dev' into smarttub-filtration-…
mdz 70585f3
Merge remote-tracking branch 'upstream/dev' into smarttub-filtration-…
mdz d2da1f2
remove required
mdz 8d97119
Merge remote-tracking branch 'upstream/dev' into smarttub-filtration-…
mdz 3c4df54
Merge remote-tracking branch 'upstream/dev' into smarttub-filtration-…
mdz a75e836
add properties for clarity
mdz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| """SmartTub integration.""" | ||
| """Base classes for SmartTub entities.""" | ||
| import logging | ||
|
|
||
| import smarttub | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| set_primary_filtration: | ||
|
mdz marked this conversation as resolved.
Outdated
|
||
| name: Update primary filtration settings | ||
| description: Updates the primary filtration settings | ||
| target: | ||
| entity: | ||
| integration: smarttub | ||
| domain: sensor | ||
| fields: | ||
| duration: | ||
| name: Duration | ||
| description: The desired duration of the primary filtration cycle | ||
| required: true | ||
| default: 8 | ||
| selector: | ||
| number: | ||
| min: 1 | ||
| max: 24 | ||
| unit_of_measurement: "hours" | ||
| mode: slider | ||
| example: 8 | ||
| start_hour: | ||
| description: The hour of the day at which to begin the primary filtration cycle | ||
| required: true | ||
| default: 0 | ||
| example: 2 | ||
| selector: | ||
| number: | ||
| min: 0 | ||
| max: 23 | ||
| unit_of_measurement: "hour" | ||
|
|
||
| set_secondary_filtration: | ||
| name: Update secondary filtration settings | ||
| description: Updates the secondary filtration settings | ||
| target: | ||
| entity: | ||
| integration: smarttub | ||
| domain: sensor | ||
| fields: | ||
| mode: | ||
| description: The secondary filtration mode. | ||
| selector: | ||
| select: | ||
| options: | ||
| - "frequent" | ||
| - "infrequent" | ||
| - "away" | ||
| required: true | ||
| example: "frequent" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.