Use common strings in traccar config flow#40959
Closed
springstan wants to merge 1 commit intohome-assistant:devfrom
Closed
Use common strings in traccar config flow#40959springstan wants to merge 1 commit intohome-assistant:devfrom
springstan wants to merge 1 commit intohome-assistant:devfrom
Conversation
probot-home-assistant
Bot
added
Hacktoberfest
code-quality
integration: traccar
small-pr
SNoof85
approved these changes
Oct 1, 2020
ludeeus
requested changes
Oct 1, 2020
| }, | ||
| "abort": { | ||
| "one_instance_allowed": "Only a single instance is necessary.", | ||
| "single_instance_allowed": "[%key:common::config_flow::abort::single_instance_allowed%]", |
Member
There was a problem hiding this comment.
For webhook flows the key needs to be one_instance_allowed
Member
Author
There was a problem hiding this comment.
Oh okay did not know that, will close this PR and open another one to add this string to the base strings.
Member
There was a problem hiding this comment.
Probably better to change the Base class for webhook flows to use the same as others ;)
Consistency 🎉
Member
Author
There was a problem hiding this comment.
That is an even better idea 😄
I am a big fan of consistency as well 🎊
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Use common strings in traccar config flow as described in #40578
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: