Skip to content

Use common strings in traccar config flow #40959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
springstan wants to merge 1 commit into from
Closed

Use common strings in traccar config flow #40959

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion homeassistant/components/traccar/strings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
}
},
"abort": {
"one_instance_allowed": "Only a single instance is necessary.",
"single_instance_allowed": "[%key:common::config_flow::abort::single_instance_allowed%]",
Copy link
Copy Markdown
Member

@ludeeus ludeeus Oct 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For webhook flows the key needs to be one_instance_allowed

Copy link
Copy Markdown
Member Author

@springstan springstan Oct 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh okay did not know that, will close this PR and open another one to add this string to the base strings.

Copy link
Copy Markdown
Member

@ludeeus ludeeus Oct 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably better to change the Base class for webhook flows to use the same as others ;)

Consistency 🎉

Copy link
Copy Markdown
Member Author

@springstan springstan Oct 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is an even better idea 😄
I am a big fan of consistency as well 🎊

"not_internet_accessible": "Your Home Assistant instance needs to be accessible from the internet to receive messages from Traccar."
},
"create_entry": {
Expand Down