Use single_instance_allowed for webhook config flows#40965
Merged
MartinHjelmare merged 1 commit intohome-assistant:devfrom Oct 1, 2020
Conversation
MartinHjelmare
requested changes
Oct 1, 2020
Member
MartinHjelmare
left a comment
MartinHjelmare
left a comment
There was a problem hiding this comment.
Please finish one integration per PR instead so we can keep track of what integrations are done.
Member
Author
|
I can see where you are coming from but once it has been changed |
MartinHjelmare
approved these changes
Oct 1, 2020
| """Handle a user initiated set up flow to create a webhook.""" | ||
| if not self._allow_multiple and self._async_current_entries(): | ||
| return self.async_abort(reason="one_instance_allowed") | ||
| return self.async_abort(reason="single_instance_allowed") |
Member
There was a problem hiding this comment.
I didn't see that you're changing this string. Then it's ok to do all integrations in one PR for this string.
springstan
deleted the
use-single-instance-allowed-base-string-for-webhook-config-flows
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Following the suggestion in #40959 (comment)
Webhook config flows previously used the base string
one_instance_allowedthis has now been replaced bysingle_instance_allowedto be consistent with non-webook config flows.cc @ludeeus
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: