Skip to content

Remove zeroconf options from homekit#35687

Merged
bdraco merged 5 commits into
home-assistant:devfrom
bdraco:pyhap_zc_cleanup
Jun 2, 2020
Merged

Remove zeroconf options from homekit#35687
bdraco merged 5 commits into
home-assistant:devfrom
bdraco:pyhap_zc_cleanup

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented May 16, 2020

Breaking change

homekit uses the system shared zeroconf instance which
makes the interface choice option controlled by the
zeroconf integration setting.

If you were previously setting the interface choice in homekit, you
should set the interface choice in zeroconf instead.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@bdraco bdraco added the waiting-for-upstream We're waiting for a change upstream label May 16, 2020
@bdraco bdraco added breaking-change and removed waiting-for-upstream We're waiting for a change upstream labels May 28, 2020
@bdraco bdraco force-pushed the pyhap_zc_cleanup branch from 44db7bb to 0898a27 Compare May 29, 2020 20:25
@bdraco bdraco marked this pull request as ready for review May 29, 2020 20:30
@bdraco bdraco added dependency-bump Pull requests that update a dependency file and removed docs-missing labels May 29, 2020
@bdraco bdraco marked this pull request as draft May 29, 2020 21:01
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented May 29, 2020

Need to fix cv.deprecated before this can be ready for review

@bdraco bdraco marked this pull request as ready for review May 29, 2020 22:15
@bdraco bdraco mentioned this pull request May 30, 2020
27 tasks
@bdraco bdraco removed the dependency-bump Pull requests that update a dependency file label Jun 1, 2020
bdraco added 4 commits June 1, 2020 15:52
homekit uses the system shared zeroconf instance which
made the interface choice option controlled by the
zeroconf integration setting.
Comment thread homeassistant/components/homekit/__init__.py Outdated
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Jun 2, 2020

FAILED tests/components/buienradar/test_camera.py::test_belgium_country[pyloop]

#36394

FAILED tests/components/plex/test_config_flow.py::test_manual_config[pyloop]

#36391
Test failures are unrelated

@bdraco bdraco merged commit 5f4fdaa into home-assistant:dev Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants