Refactor Synology entries to allow not fetching the API when it's disabled + add security binary sensor

[Quentame]

Breaking change

• The following sensors are now binary sensors:
  • disk_exceed_bad_sector_thr
  • disk_below_remain_life_thr
• The following sensors have been removed:
  • volume type (RAID, SHR ...)
  • disk name (Drive [X])
  • disk device (/dev/sd[Y])
• The disk and volume sensors have been replaced: sensor.synology_status_sda to sensor.synology_drive_1_status, sensor.synology_average_disk_temp_volume_1 to sensor.synology_volume_1_average_disk_temp, etc.

Proposed change

• add Synology DSM Security binary sensor (enabled by default)
• use device name instead of id in names
• add device type to name
• show disk manufacturer, model and firmware version in devices
• some entries are disabled by default (entity_registry_enabled_default)
• binary sensor + sensor uses device_class when possible
• do not fetch a concerned API if all entries of it are disabled

Changes:

• entity unique_id now uses key instead of label
• entity entity_id changes for disk and volume: example from sensor.synology_status_sda to sensor.synology_drive_1_status, or from sensor.synology_average_disk_temp_volume_1 to sensor.synology_volume_1_average_disk_temp
• now binary sensor:
  • disk_exceed_bad_sector_thr
  • disk_below_remain_life_thr
• removed sensor:
  • volume type (RAID, SHR ...)
  • disk name (Drive [X])
  • disk device (/dev/sd[Y])

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request: Refactor Synology DSM home-assistant.io#13536

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

[probot-home-assistant]

Hey there @ProtoThis, mind taking a look at this pull request as its been labeled with a integration (synology_dsm) you are listed as a codeowner for? Thanks!
_{^{(message by CodeOwnersMention)}}

[Quentame]

Devices uses device name & type:

Before: Synology NAS (sda), Synology NAS (sdb), Synology NAS (sdc), Synology NAS (volume_1), and manufacturer and model were the same as the first device.

---

Device with one entity disabled by default + 2 first entities as binary (inactif means inactive):

---

Main device with few entities enabled + the new secured binary sensor (sécurisé means secured):

Main device with all entities disabled, SynoCoreUtilization + SynoCoreSecurity APIs are not fetched:

[MartinHjelmare]

Sounds like lots of things are going on in this PR. I would advice to split each thing into its own PR. If we need to write + in the PR header to sum up the changes, it's a sign that we should split the PR.

[bdraco]

I haven't forgotten about this. I'll get to the review as soon as 0.110 items calm down

[bdraco]

The subscribe code looks good 🍾

Just a few minor cleanups and I'll start testing.

[bdraco]

Testing looks good on my test instance

[bdraco]

I had some entities that didn't get migrated with the unique id changes

[Quentame]

Maybe I should add a " - " between the disk/volume name and its type 🤔

[bdraco]

Screenshots of the ones that didn't migrate successfully

[Quentame]

Screenshots of the ones that didn't migrate successfully

Those are normal, those sensors are either removed or changed from sensor to binary_sensor

[bdraco]

Those are normal, those sensors are either removed or changed from sensor to binary_sensor

I adjusted the breaking change section to reflect that. Please check

[Quentame]

Those are normal, those sensors are either removed or changed from sensor to binary_sensor

I adjusted the breaking change section to reflect that. Please check

Thanks, good 👍

[Quentame]

Just adding the caret before merging

[Quentame]

Python3.7 failing test not related to this PR.

Related to buienradar integration test_camera.test_expire_delta
See: https://dev.azure.com/home-assistant/Core/_build/results?buildId=45847&view=logs&j=67510a0b-4400-5e74-cb95-9572caf5ca54&t=f8fe93fb-5ebb-59cc-455e-c0f2d9ad3a42&l=278

Made an issue of it #36382