Skip to content

Refactor Synology DSM#13536

Merged
frenck merged 1 commit into
home-assistant:nextfrom
Quentame:synology_dsm/rework
Jun 2, 2020
Merged

Refactor Synology DSM#13536
frenck merged 1 commit into
home-assistant:nextfrom
Quentame:synology_dsm/rework

Conversation

@Quentame
Copy link
Copy Markdown
Member

@Quentame Quentame commented May 20, 2020

Proposed change

Follows changes in home-assistant/core#35565

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @Quentame 👍

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added awaits-parent Awaits the merge of an parent PR new-feature This PR adds documentation for a new Home Assistant feature to an existing integration labels May 21, 2020
@probot-home-assistant probot-home-assistant Bot added the parent-merged The parent PR has been merged already label Jun 2, 2020
@frenck frenck merged commit 94ebbb6 into home-assistant:next Jun 2, 2020
@probot-home-assistant probot-home-assistant Bot removed awaits-parent Awaits the merge of an parent PR parent-merged The parent PR has been merged already labels Jun 2, 2020
@Quentame Quentame deleted the synology_dsm/rework branch June 2, 2020 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants