Skip to content

Fix Synology DSM discovery: KeyError: 'host' #35069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Quentame wants to merge 1 commit into from
Closed

Fix Synology DSM discovery: KeyError: 'host' #35069

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion homeassistant/components/synology_dsm/config_flow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ async def async_step_2sa(self, user_input, errors=None):
def _host_already_configured(self, hostname):
"""See if we already have a host matching user input configured."""
existing_hosts = {
entry.data[CONF_HOST] for entry in self._async_current_entries()
entry.data.get(CONF_HOST) for entry in self._async_current_entries()

@bdraco bdraco May 2, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the case where it defaults to localhost when its missing?

@Quentame Quentame May 2, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The host is actually required, but it was to fix #34954 until we remove this function to check _macs_already_configured as agrred here #34888 (comment)

Needed stuffs to get the MAC addresses are on 0.8.0 and updated in this PR #35068, and throught this was a breaking change.

But if you correct the MAC addresses, we actually don't need this PR.

(I hope I made myself clear 馃槃)

@bdraco bdraco May 2, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I converted this to a draft so it doesn't merge as we should probably fix the duplicate discovery issue instead

@Quentame Quentame May 2, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, 0.8.0 adds dsm_api.network.macs to do so 馃槈

Closing this PR

}
return hostname in existing_hosts

Expand Down