Fix Synology DSM discovery: KeyError: 'host'#35069
Fix Synology DSM discovery: KeyError: 'host'#35069Quentame wants to merge 1 commit intohome-assistant:devfrom
Conversation
probot-home-assistant
Bot
added
bugfix
integration: synology_dsm
|
Hey there @ProtoThis, mind taking a look at this pull request as its been labeled with a integration ( |
| """See if we already have a host matching user input configured.""" | ||
| existing_hosts = { | ||
| entry.data[CONF_HOST] for entry in self._async_current_entries() | ||
| entry.data.get(CONF_HOST) for entry in self._async_current_entries() |
There was a problem hiding this comment.
This is the case where it defaults to localhost when its missing?
There was a problem hiding this comment.
The host is actually required, but it was to fix #34954 until we remove this function to check _macs_already_configured as agrred here #34888 (comment)
Needed stuffs to get the MAC addresses are on 0.8.0 and updated in this PR #35068, and throught this was a breaking change.
But if you correct the MAC addresses, we actually don't need this PR.
(I hope I made myself clear 😄)
There was a problem hiding this comment.
I converted this to a draft so it doesn't merge as we should probably fix the duplicate discovery issue instead
There was a problem hiding this comment.
Ok, 0.8.0 adds dsm_api.network.macs to do so 😉
Closing this PR
3 participants
Proposed change
Fix #34954
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: