Bump python-synology to 0.8.0 + Fix disk space incorrect sensor type#35068
Merged
Quentame merged 2 commits intohome-assistant:devfrom May 2, 2020
Merged
Bump python-synology to 0.8.0 + Fix disk space incorrect sensor type#35068Quentame merged 2 commits intohome-assistant:devfrom
Quentame merged 2 commits intohome-assistant:devfrom
Conversation
|
Hey there @ProtoThis, mind taking a look at this pull request as its been labeled with a integration ( |
bdraco
reviewed
May 2, 2020
bdraco
reviewed
May 2, 2020
bdraco
reviewed
May 2, 2020
Member
Author
|
I am actually not sure if this is a breaking change, can you tell me @bdraco ? Maybe HA interpolate "4.1 Tb" to "4.1", because HA is showing a graph, and not a line (like the Nice values in the "history" panel too. If not breaking change, should be added to 0.109.X |
Member
|
@Quentame I'd class it as a bugfix to fix the missing units on disk space used. |
Member
Author
|
Ok, changing |
20 tasks
balloob
pushed a commit
that referenced
this pull request
May 2, 2020
…35068) * Fix Synology disk space incorrect sensor type * Review 1
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Proposed change
Bump python-synology to 0.8.0:
volume_size_total+volume_size_usedare numbers with always TeraBytes as unit.Release notes : https://github.com/ProtoThis/python-synology/releases/tag/0.8.0
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: