Remove fortigate integration#34586
Conversation
|
Shouldn't this be deprecated first? |
|
sorry @frenck, how do I deprecate ? |
|
added deprecation patch in home-assistant/home-assistant.io#13197 |
MartinHjelmare
left a comment
There was a problem hiding this comment.
Please also update .coveragerc:
Line 238 in e13f78d
|
But, yeah, deprecation is preferred, so do that instead if possible. ☺ |
|
Log a warning message when setting up the integration, telling the user why it's deprecated and when it'll be removed. It's also possible to use our deprecated config validator: |
|
@MartinHjelmare "when it'll be removed" I'll create another PR for the deprecation |
|
Right now our standard time for deprecation is two minor releases, ie 6 weeks. |
|
I could add the cv.deprecated, but this is only for every config setting, not the integration itself, is there a global deprecation function ? |
|
We would wrap the CONFIG_SCHEMA = vol.Schema(
vol.All(
cv.deprecated(DOMAIN),
{DOMAIN: vol.Schema(...)},
),
extra=vol.ALLOW_EXTRA,
) |
|
Thank you, I added the PR #34854 to warn about the deprecation first |
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
|
We can merge this now that the beta for 0.111.0 is cut. This PR will go out in 0.112.0. Please make a PR to the docs next branch removing the pages for the integration. Check with the docs team for further instructions. When we have a docs PR linked here we can merge. |
|
@kifeo The only thing left right now, I think, is to rebase this PR in order to resolve the merge conflicts it currently has. |
removed the fortigate intgration
removed the fortigate intgration
Breaking change
The forigate integration has been removed in favor of the foritos integration.
Proposed change
remove the fortigate intgration
as stated in #32057, I will use fortios integration instead to only have one fortinet related integration.
removed the fortigate integration :
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: