Skip to content

Remove the fortigate integration#13662

Closed
kifeo wants to merge 1 commit into
home-assistant:nextfrom
kifeo:fortigate-removal
Closed

Remove the fortigate integration#13662
kifeo wants to merge 1 commit into
home-assistant:nextfrom
kifeo:fortigate-removal

Conversation

@kifeo
Copy link
Copy Markdown
Contributor

@kifeo kifeo commented Jun 4, 2020

Proposed change

remove the fortigate integration

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added has-parent This PR has a parent PR in another repo in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Jun 4, 2020
@probot-home-assistant probot-home-assistant Bot added the current This PR goes into the current branch label Jun 4, 2020
@kifeo kifeo changed the base branch from current to next June 4, 2020 08:19
@klaasnicolaas klaasnicolaas removed the needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch label Jun 4, 2020
@klaasnicolaas
Copy link
Copy Markdown
Member

@kifeo Can you fix the merge conflict? Also it's not necessary to remove a line from CODEOWNERS, because it's auto generated 😉

@kifeo kifeo force-pushed the fortigate-removal branch from 2e99e88 to e1dcd8d Compare June 4, 2020 13:33
@kifeo kifeo changed the title remove the fortigate integration WIP: remove the fortigate integration Jun 4, 2020
@probot-home-assistant probot-home-assistant Bot added next This PR goes into the next branch and removed current This PR goes into the current branch labels Jun 4, 2020
@kifeo kifeo force-pushed the fortigate-removal branch 2 times, most recently from b69f1c0 to ecaa5ed Compare June 4, 2020 13:44
@kifeo
Copy link
Copy Markdown
Contributor Author

kifeo commented Jun 4, 2020

@klaasnicolaas I messed up with e1dcd8d, but cannot find how to resolve ?

@frenck frenck self-assigned this Jun 23, 2020
@frenck frenck changed the title WIP: remove the fortigate integration Remove the fortigate integration Jun 23, 2020
@frenck frenck added the cleanup label Jun 23, 2020
@frenck frenck force-pushed the fortigate-removal branch from ecaa5ed to e9e7f3d Compare June 23, 2020 22:10
@frenck
Copy link
Copy Markdown
Member

frenck commented Jun 23, 2020

I've rebased it, but now I notice it is removing the wrong integration.
Will close this one up and create a new PR.

@frenck frenck closed this Jun 23, 2020
@probot-home-assistant probot-home-assistant Bot removed the in-progress This PR/Issue is currently being worked on label Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup has-parent This PR has a parent PR in another repo next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants