Skip to content

deprecate fortigate integration#13197

Merged
fabaff merged 4 commits into
home-assistant:currentfrom
kifeo:patch-1
May 5, 2020
Merged

deprecate fortigate integration#13197
fabaff merged 4 commits into
home-assistant:currentfrom
kifeo:patch-1

Conversation

@kifeo
Copy link
Copy Markdown
Contributor

@kifeo kifeo commented Apr 28, 2020

Proposed change

Deprecate the fortigate integration

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

the fortigate integration will be remove in order to only use the fortios one
@probot-home-assistant probot-home-assistant Bot added has-parent This PR has a parent PR in another repo in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Apr 28, 2020
@probot-home-assistant
Copy link
Copy Markdown

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.

@probot-home-assistant probot-home-assistant Bot added the current This PR goes into the current branch label Apr 28, 2020
@klaasnicolaas klaasnicolaas removed in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Apr 28, 2020
Comment thread source/_integrations/fortigate.markdown Outdated
@klaasnicolaas klaasnicolaas added the in-progress This PR/Issue is currently being worked on label Apr 28, 2020
kifeo added 2 commits April 28, 2020 12:33
highlighted text and added link to the fortios integration
@kifeo kifeo requested a review from klaasnicolaas April 30, 2020 07:12
@frenck frenck added the parent-merged The parent PR has been merged already label Apr 30, 2020
@fabaff fabaff dismissed klaasnicolaas’s stale review May 5, 2020 08:44

Comment addressed

@fabaff fabaff merged commit 357bc3f into home-assistant:current May 5, 2020
@probot-home-assistant probot-home-assistant Bot removed in-progress This PR/Issue is currently being worked on parent-merged The parent PR has been merged already labels May 5, 2020
Comment on lines +15 to +17
<div class='note warning'>
This integration will be deprecated. Please use the [FortiOS](/integrations/fortios) integration.
</div>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now broken on our website as the HTML & Markdown context isn't switched.
At least one new line is needed after switching between HTML & Markdown.

So after the opening div and before the closing div an empty line needed to be put.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

current This PR goes into the current branch has-parent This PR has a parent PR in another repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants