Skip ignored hosts when checking existing config entries in config flow#34280
Merged
balloob merged 7 commits intohome-assistant:devfrom Apr 16, 2020
Merged
Skip ignored hosts when checking existing config entries in config flow#34280balloob merged 7 commits intohome-assistant:devfrom
balloob merged 7 commits intohome-assistant:devfrom
Conversation
Member
|
Could we test this by adding a |
Contributor
Author
|
Thanks for that suggestion @MartinHjelmare was struggling to figure out how to test this, and by adding tests I found that my logic was flawed. Pushing a new commit shortly |
16 tasks
balloob
reviewed
Apr 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
There was a bug report that pointed out that when a
viziodevice has been ignored, config flow will fail because it expected thehostkey but the ignored config entry doesn't have it. This change only checks for expected keys when the config entry is not an ignored one. I wasn't sure how to test this, I found that theconfigcomponent does a test like this by calling the WebSocket client to ignore an entry but that seemed messy. Happy to add tests if needed. If there's another hotfix version released for 0.108, it would be great to include this in that, otherwise it should go out with 0.109Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: